[upstream_utils] Add googletest#6820
Conversation
calcmogul
left a comment
calcmogul
left a comment
There was a problem hiding this comment.
We use thirdparty instead of third_party for all the other upstream_utils imports.
|
So in its current state this splits Would it be OK to leave the file structure how it is natively? If so I can undo the split and remove a lot of the extra churn |
PeterJohnson
changed the title
|
|
||
| artifactId = baseArtifactId | ||
| groupId artifactGroupId | ||
| version wpilibVersioning.version.get() |
There was a problem hiding this comment.
@ThadHouse this will change versioning from the current thirdparty-googletest, correct? Is that an issue at all, or does this actually make things easier?
There was a problem hiding this comment.
Makes things slightly easier, although it will require a new version of native-utils to actually pick up. Otherwise the old one will be picked up, which will be fine for now because its a static only library, and not part of the ABI of anything shipped.
calcmogul
left a comment
calcmogul
left a comment
There was a problem hiding this comment.
This needs to be rebased to use the new upstream_utils API.
pjreiniger
force-pushed
the
upstream_gtest
branch
from
c82aaa3 to
6468163
Compare
This was rendered useless when googletest was added to the allwpilib monorepo wpilibsuite/allwpilib#6820 Signed-off-by: Jade Turner <spacey-sooty@proton.me>
This was rendered useless when googletest was added to the allwpilib monorepo wpilibsuite/allwpilib#6820 Signed-off-by: Jade Turner <spacey-sooty@proton.me>
5 participants
Fixes #6811
Adds gtest to the source tree.