[robotpy parity] Write a deploy.json log file when deploying code by spacey-sooty · Pull Request #690 · wpilibsuite/GradleRIO

spacey-sooty · 2023-11-28T13:17:30Z

Resolves #689

ThadHouse · 2023-12-07T06:08:22Z

You need to be using a gradle task for this, with properly mapped inputs and outputs. Additionally, the output needs to go into somewhere in the build folder. Everything needs to be fully cross platform. This should also use grgit for the git commands, using the same version in the gradle-versioning-plugin we publish. It also needs to not fail if the project is not a git repo.

spacey-sooty · 2024-03-27T14:03:11Z

This way this will write the deploy file to the output dir and we can add to the build template a StaticFileDeploy object

src/main/java/edu/wpi/first/gradlerio/deploy/CreateLogFileTask.java

Requires wpilibsuite/GradleRIO#690

just need to get the data get git data write to build/ instead

- grgit not fully used see ajoberstar/grgit#398 - doesn't fully use tasks properly I don't think - file needs to be properly set to output dir revert plugin changes fix: use gradle output dir call the thingy

requires ajoberstar/grgit#399 Try use grgit to check if in git repo not sure if this works see ajoberstar/grgit#397 fix grgit

naming

spacey-sooty · 2024-12-01T14:41:49Z

@ThadHouse can you review this?

src/main/java/edu/wpi/first/gradlerio/deploy/CreateLogFileTask.java

ThadHouse · 2024-12-01T15:20:34Z

src/main/java/edu/wpi/first/gradlerio/deploy/CreateLogFileTask.java

+      deployFile = new File(path);
+    }
+
+    public void setGitDirectory(String dir) {


This should be a string property

I can't find a StringProperty class in the Gradle API?

src/main/java/edu/wpi/first/gradlerio/deploy/FRCExtension.java

build.gradle

Signed-off-by: Jade Turner <[email protected]>

spacey-sooty force-pushed the deploy_data branch from 49a6c50 to 2c819e6 Compare December 7, 2023 01:52

spacey-sooty marked this pull request as ready for review December 7, 2023 05:51

spacey-sooty force-pushed the deploy_data branch from b6d08c1 to 5d47416 Compare December 7, 2023 06:11

This comment was marked as outdated.

Sign in to view

spacey-sooty force-pushed the deploy_data branch from 5d47416 to 03c70fa Compare March 27, 2024 13:35

spacey-sooty commented Mar 27, 2024

View reviewed changes

src/main/java/edu/wpi/first/gradlerio/deploy/CreateLogFileTask.java Show resolved Hide resolved

spacey-sooty added a commit to spacey-sooty/vscode-wpilib that referenced this pull request Mar 28, 2024

Update build templates for gradlerio deploy files

32e3a8c

Requires wpilibsuite/GradleRIO#690

spacey-sooty mentioned this pull request Mar 28, 2024

Update build templates for GradleRIO deploy.json wpilibsuite/vscode-wpilib#665

Open

spacey-sooty force-pushed the deploy_data branch from ff82058 to df1512a Compare March 28, 2024 06:38

spacey-sooty and others added 7 commits June 30, 2024 20:16

start working on deploy data

e0b462a

create file to be deployed

d63d80a

just need to get the data get git data write to build/ instead

start switching to proper gradle way

32cbe68

- grgit not fully used see ajoberstar/grgit#398 - doesn't fully use tasks properly I don't think - file needs to be properly set to output dir revert plugin changes fix: use gradle output dir call the thingy

Use grgit for hash and branchname

b1866f5

requires ajoberstar/grgit#399 Try use grgit to check if in git repo not sure if this works see ajoberstar/grgit#397 fix grgit

should be working now

a2c42c7

pass args to grgit.open

e3dcd14

naming

jgit

3e09be4

spacey-sooty force-pushed the deploy_data branch from 8bbe76f to 3e09be4 Compare June 30, 2024 12:16

spacey-sooty added 2 commits September 10, 2024 11:46

Merge branch 'main' into deploy_data

95b8941

Merge branch 'main' into deploy_data

df72f28