Skip to content

[RocketCDN] Fix French price format handling for RocketCDN pricing display#8139

Merged
Miraeld merged 1 commit intodevelopfrom
fix/french-price-format-rocketcdn
Mar 10, 2026
Merged

[RocketCDN] Fix French price format handling for RocketCDN pricing display#8139
Miraeld merged 1 commit intodevelopfrom
fix/french-price-format-rocketcdn

Conversation

@Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Mar 10, 2026

Description

Fixes #xxx
Fix the price format with a comma

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

What was tested

With this PR:
Screenshot 2026-03-10 at 02 13 50

How to test

Just look the price style

Affected Features & Quality Assurance Scope

RocketCDN UI

Technical description

Documentation

Handle the comma.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

No test for this

@Miraeld Miraeld changed the title [RocketCDNFix French price format handling for RocketCDN pricing display [RocketCDN] Fix French price format handling for RocketCDN pricing display Mar 10, 2026
@Miraeld Miraeld self-assigned this Mar 10, 2026
@Miraeld Miraeld requested a review from a team March 10, 2026 01:21
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -0.10%) 100.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (86fff35) 42555 19394 45.57%
Head commit (5ab6ffa) 42555 (+0) 19394 (+0) 45.57% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#8139) 6 6 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@Miraeld Miraeld added this pull request to the merge queue Mar 10, 2026
Merged via the queue into develop with commit e7815b7 Mar 10, 2026
16 of 18 checks passed
@Miraeld Miraeld deleted the fix/french-price-format-rocketcdn branch March 10, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant