-
Notifications
You must be signed in to change notification settings - Fork 89
fix(cli): use fs.symlinkSync for paths with spaces, show version in status #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
000ba00
fix(cli): use fs.symlinkSync for paths with spaces, show version in s…
evgeniko 50d6a12
style: run prettier on changed files
evgeniko c1cd680
fix(cli): guard against malformed version file
evgeniko a7a02c4
fix(cli): improve version check and add end-to-end symlink test
evgeniko 0940774
style: run prettier on test file
evgeniko ead475a
Merge branch 'main' into fix/symlink-spaces-in-path
evgeniko 6e75153
Merge branch 'main' into fix/symlink-spaces-in-path
evgeniko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import fs from "fs"; | ||
|
|
||
| export function nttVersion(): { | ||
| version: string; | ||
| commit: string; | ||
| path: string; | ||
| remote: string; | ||
| } | null { | ||
| const nttDir = `${process.env.HOME}/.ntt-cli`; | ||
| try { | ||
| const versionFile = fs.readFileSync(`${nttDir}/version`).toString().trim(); | ||
| const [commit, installPath, version, remote] = versionFile.split("\n"); | ||
| return { version, commit, path: installPath, remote }; | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } catch { | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| export function formatNttVersion(): string { | ||
| const ver = nttVersion(); | ||
| if (!ver) { | ||
| return "ntt version: unknown"; | ||
| } | ||
| const { version, commit, path, remote } = ver; | ||
| const defaultPath = `${process.env.HOME}/.ntt-cli/.checkout`; | ||
| const remoteString = remote.includes("wormhole-foundation") | ||
| ? "" | ||
| : `${remote}@`; | ||
| if (path === defaultPath) { | ||
| return `ntt v${version} (${remoteString}${commit})`; | ||
| } else { | ||
| return `ntt v${version} (${remoteString}${commit}) from ${path}`; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.