-
Notifications
You must be signed in to change notification settings - Fork 89
feat: migrate from npm to bun package manager #766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b74397d
feat: migrate from npm to bun package manager
DBosley 8b20338
fix(ci): free disk space before large Docker builds
DBosley 2a20c12
fix(docker): use dummy workspaces for frozen lockfile support
DBosley 1349092
fix(ci): improve Tilt test stability and configuration
DBosley 91be61b
fix(docker): copy real workspace package.json instead of dummies
DBosley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,12 +19,12 @@ Do not change the dependencies of the package.json by hand! | |
|
|
||
| Instead: | ||
|
|
||
| - When initially installing OR pulling what has been changed: `npm ci`. | ||
| If you do not do this, you may not get exactly what is specified in the file, inadvertently update dependencies, or even pull exploits down to your machine! **Never use `npm install` for this use case**. | ||
| - When needing to add or update a package: `npm i <package>@<version>`. If you do not do this, you may inadvertently update other packages or fail to update the lock file. | ||
| - When needing to remove a package: `npm r <package>`. If you do not do this, you may inadvertently update other packages or fail to update the lock file. | ||
| - When initially installing OR pulling what has been changed: `bun ci`. | ||
| If you do not do this, you may not get exactly what is specified in the file, inadvertently update dependencies, or even pull exploits down to your machine! **Never use `bun install` for this use case**. | ||
| - When needing to add or update a package: `bun add <package>@<version>`. If you do not do this, you may inadvertently update other packages or fail to update the lock file. | ||
| - When needing to remove a package: `bun remove <package>`. If you do not do this, you may inadvertently update other packages or fail to update the lock file. | ||
|
|
||
| Always commit your `package-lock.json`. | ||
| Always commit your `bun.lock`. | ||
|
|
||
| Using specific versions improves security because package versions cannot be overwritten after they are released. | ||
|
|
||
|
|
@@ -33,33 +33,33 @@ Using specific versions improves security because package versions cannot be ove | |
| ##### If installing a package locally | ||
|
|
||
| - Copy in package.json and the lock file | ||
| - Then run `npm ci` | ||
| - Then run `bun ci` | ||
|
|
||
| ```dockerfile | ||
| # NOTE: Dockerfile must be pinned too | ||
| FROM node:18.19.0-alpine@sha256:12345... | ||
| FROM oven/bun:1.2-alpine@sha256:12345... | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| # Include package files | ||
| COPY package.json package-lock.json ./ | ||
| COPY package.json bun.lock ./ | ||
|
|
||
| # Use npm ci so that packages are not upgraded | ||
| RUN npm ci | ||
| # Use bun ci so that packages are not upgraded | ||
| RUN bun ci | ||
|
|
||
| ... | ||
| ``` | ||
|
|
||
| ##### If installing a package globally | ||
|
|
||
| - Use `npm i <package>@<version>` | ||
| - Use `bun add -g <package>@<version>` | ||
|
|
||
| ```dockerfile | ||
| # NOTE: Dockerfile must be pinned too | ||
| FROM node:18.19.0-alpine@sha256:12345... | ||
| FROM oven/bun:1.2-alpine@sha256:12345... | ||
|
|
||
| # Pin global packages to specific versions | ||
| RUN npm install -g [email protected] | ||
| RUN bun add -g [email protected] | ||
|
|
||
| ... | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.