Various changes #46
Open
Various changes #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stener may not get removed on some API 16+ devices
…spective TextView
…utListener from being called infinitely (for reasons yet unknown) which eventually causes an OutOfMemoryError
…of a title and description
…called soon after setting it, which ensures that the listener gets called and removed, and doesn't get called infinitely later on
Owner
|
Wow, these are a lot of commits, thanks! 👍 |
Open
Owner
|
@jkreiser I've cherry-picked many of your commits into master, but I couldn't understand some of it, so I didn't include them, I will leave comments in those individual commits. Sorry for the late response, and thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore the name of the branch, I've added other things to it.