Skip to content

Conversation

@michi-dev
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Closes #70.

I have added more functionality than described in the issue #70. This needs a bit further explanation. I have divorced any shipping / billing address in three parts:

  • person (firstname, lastname)
  • address (address1,address2, city, state, postcode, country)
  • company (company_name)

Every customer, who gets generated, has those three parts. Every part has a random generation. I added the feature that at the customer generation in Customer.php:
possibility A: billing = shipping (was done before)
possibility B: 1/2 billing != shipping (added with this pull request)

therefore, the shipping address can have different details for

  • personal information (other person / same person)
  • location information (other location / same location)
  • company name (B2B (same company), B2B (different companies), B2C, C2B, C2C)

every part has its own random generation. with all three parts coming together its a unique order with in total (225) 40 combinations and therefore test cases.

How to test the changes in this Pull Request:

1.use wp wc generate customers 50 to directly test the customer generation
2.use wp wc generate orders 50 to see if the customers were correctly saved to the orders

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

Luc45
Luc45 previously approved these changes Jul 1, 2022
Copy link
Member

@Luc45 Luc45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks for contributing!

I have left just some minor readability suggestions

I'll forward this internally to be merged

image

@michi-dev
Copy link
Contributor Author

No problem, glad to see it worked @Luc45

michi-dev and others added 2 commits July 4, 2022 07:56
@masteradhoc
Copy link
Contributor

@samueljseay can u check and merge this one also?

@jonathansadowski jonathansadowski dismissed Luc45’s stale review September 23, 2022 16:56

File conflicts from out of date files

@jonathansadowski
Copy link
Contributor

Hi @michi-dev,

Apologies not getting to this sooner. It looks like there are some conflicts now. Would you mind resolving those so that we can give this a re-review?

@samueljseay
Copy link
Contributor

It looks like there are still some conflicts here @michi-dev just bumping this in case you missed it. Sorry again for the delayed response on my part.

@michi-dev
Copy link
Contributor Author

@samueljseay @jonathansadowski should now be fine - can you check?

@jonathansadowski jonathansadowski requested review from a team and jonathansadowski and removed request for a team January 4, 2023 19:55
@jonathansadowski
Copy link
Contributor

Hi @michi-dev,

Sorry for the delay in getting back to this. Looks great, thanks for your contribution!

@jonathansadowski jonathansadowski merged commit 2bec9cb into woocommerce:trunk Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Customer Adress (Shipping / Billing)

5 participants