-
Notifications
You must be signed in to change notification settings - Fork 55
Shipping billing addresses feature #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shipping billing addresses feature #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
No problem, glad to see it worked @Luc45 |
Co-authored-by: Lucas Bustamante <[email protected]>
Co-authored-by: Lucas Bustamante <[email protected]>
|
@samueljseay can u check and merge this one also? |
File conflicts from out of date files
|
Hi @michi-dev, Apologies not getting to this sooner. It looks like there are some conflicts now. Would you mind resolving those so that we can give this a re-review? |
|
It looks like there are still some conflicts here @michi-dev just bumping this in case you missed it. Sorry again for the delayed response on my part. |
|
@samueljseay @jonathansadowski should now be fine - can you check? |
|
Hi @michi-dev, Sorry for the delay in getting back to this. Looks great, thanks for your contribution! |

All Submissions:
Changes proposed in this Pull Request:
Closes #70.
I have added more functionality than described in the issue #70. This needs a bit further explanation. I have divorced any shipping / billing address in three parts:
Every customer, who gets generated, has those three parts. Every part has a random generation. I added the feature that at the customer generation in Customer.php:
possibility A: billing = shipping (was done before)
possibility B: 1/2 billing != shipping (added with this pull request)
therefore, the shipping address can have different details for
every part has its own random generation. with all three parts coming together its a unique order with in total (225) 40 combinations and therefore test cases.
How to test the changes in this Pull Request:
1.use
wp wc generate customers 50to directly test the customer generation2.use
wp wc generate orders 50to see if the customers were correctly saved to the ordersOther information:
Changelog entry
FOR PR REVIEWER ONLY: