Skip to content

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented Dec 11, 2025

All Submissions:

Changes proposed in this Pull Request:

When I ran the generate product command, I got the deprecation warning below.

Screenshot 2025-12-11 at 13 47 43

This PR updates the jdenticon to the latest version, which is compatible with PHP 8.4, to fix the issue. Note it doesn't support PHP <= 7.3 anymore; however, woocommerce already dropped support for PHP <= 7.3, so it should be fine.

See https://github.com/dmester/jdenticon-php/releases for more details.

How to test the changes in this Pull Request:

  1. In a WooCommerce site with PHP 8.2 or higher
  2. Run wp wc generate products 10
  3. Confirm that there is no deprecation warning
Screenshot 2025-12-11 at 13 47 50

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Update jdenticon to version 2.0.0 to fix deprecation warnings

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@chihsuan chihsuan self-assigned this Dec 11, 2025
@chihsuan chihsuan requested a review from layoutd December 11, 2025 05:51
Copy link
Contributor

@layoutd layoutd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM thanks for the fix @chihsuan. Had some trouble reproducing the issue, if the store has any pre-existing media items it looks like the deprecation message doesn't appear (i.e., if you prime the test site the the sample WooCommerce data, then there's no message).

@chihsuan chihsuan merged commit 585e092 into trunk Dec 12, 2025
@chihsuan chihsuan deleted the fix/jdenticon-warning branch December 12, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants