Skip to content

Optimize order date generation #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
layoutd merged 2 commits into from
Dec 11, 2025
Merged

Optimize order date generation #185

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b37c787
Optimize order date generation for batch creation
layoutd Oct 31, 2025
40d6ad6
Use a local date array and pass the value for each generated order
layoutd Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 73 additions & 12 deletions includes/Generator/Order.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,12 @@ class Order extends Generator {
/**
* Return a new order.
*
* @param bool $save Save the object before returning or not.
* @param array $assoc_args Arguments passed via the CLI for additional customization.
* @param bool $save Save the object before returning or not.
* @param array $assoc_args Arguments passed via the CLI for additional customization.
* @param string|null $date Optional date string (Y-m-d) to use for order creation. If not provided, will be generated.
* @return \WC_Order|false Order object with data populated or false when failed.
*/
public static function generate( $save = true, $assoc_args = array() ) {
public static function generate( $save = true, $assoc_args = array(), $date = null ) {
parent::maybe_initialize_generators();

$order = new \WC_Order();
Expand Down Expand Up @@ -111,7 +112,10 @@ public static function generate( $save = true, $assoc_args = array() ) {
$order->set_status( $status );
$order->calculate_totals( true );

$date = self::get_date_created( $assoc_args );
// Use provided date or generate one
if ( null === $date ) {
$date = self::get_date_created( $assoc_args );
}
$date .= ' ' . wp_rand( 0, 23 ) . ':00:00';

$order->set_date_created( $date );
Expand Down Expand Up @@ -236,11 +240,20 @@ public static function batch( $amount, array $args = array() ) {
return $amount;
}

// Pre-generate dates if date-start is provided
// This ensures chronological order: lower order IDs = earlier dates
$dates = null;
if ( ! empty( $args['date-start'] ) ) {
$dates = self::generate_batch_dates( $amount, $args );
}

$order_ids = array();

for ( $i = 1; $i <= $amount; $i ++ ) {
$order = self::generate( true, $args );
if ( ! $order ) {
// Use pre-generated date if available, otherwise pass null to generate one
$date = ( null !== $dates && ! empty( $dates ) ) ? array_shift( $dates ) : null;
$order = self::generate( true, $args, $date );
if ( ! $order instanceof \WC_Order ) {
error_log( "Batch generation failed: Order {$i} of {$amount} could not be generated" );
continue;
}
Expand Down Expand Up @@ -298,14 +311,19 @@ protected static function get_date_created( $assoc_args ) {
return $current;
}

$dates = array();
$date = strtotime( $start );
while ( $date <= strtotime( $end ) ) {
$dates[] = date( 'Y-m-d', $date );
$date = strtotime( '+1 day', $date );
// Use timestamp-based random selection for single order generation
$start_timestamp = strtotime( $start );
$end_timestamp = strtotime( $end );
$days_between = (int) ( ( $end_timestamp - $start_timestamp ) / DAY_IN_SECONDS );

// If start and end are the same day, return that date (time will be randomized in generate())
if ( 0 === $days_between ) {
return date( 'Y-m-d', $start_timestamp );
}

return $dates[ array_rand( $dates ) ];
// Generate random offset in days and add to start timestamp
$random_days = wp_rand( 0, $days_between );
return date( 'Y-m-d', $start_timestamp + ( $random_days * DAY_IN_SECONDS ) );
}

/**
Expand Down Expand Up @@ -790,4 +808,47 @@ protected static function calculate_refund_date( $order, $previous_refund = null
$random_days = wp_rand( 0, $max_days );
return date( 'Y-m-d H:i:s', strtotime( $base_date->date( 'Y-m-d H:i:s' ) ) + ( $random_days * DAY_IN_SECONDS ) );
}

/**
* Generate an array of sorted dates for batch order creation.
* Ensures chronological order when creating multiple orders.
*
* @param int $count Number of dates to generate.
* @param array $args Arguments containing date-start and optional date-end.
* @return array Sorted array of date strings (Y-m-d).
*/
protected static function generate_batch_dates( $count, $args ) {
$current = date( 'Y-m-d', time() );

if ( ! empty( $args['date-start'] ) && empty( $args['date-end'] ) ) {
$start = $args['date-start'];
$end = $current;
} elseif ( ! empty( $args['date-start'] ) && ! empty( $args['date-end'] ) ) {
$start = $args['date-start'];
$end = $args['date-end'];
} else {
// No date range specified, return array of current dates
return array_fill( 0, $count, $current );
}

$start_timestamp = strtotime( $start );
$end_timestamp = strtotime( $end );
$days_between = (int) ( ( $end_timestamp - $start_timestamp ) / DAY_IN_SECONDS );

// If start and end dates are the same, return array of that date
if ( 0 === $days_between ) {
return array_fill( 0, $count, date( 'Y-m-d', $start_timestamp ) );
}

$dates = array();
for ( $i = 0; $i < $count; $i++ ) {
$random_days = wp_rand( 0, $days_between );
$dates[] = date( 'Y-m-d', $start_timestamp + ( $random_days * DAY_IN_SECONDS ) );
}

// Sort chronologically so lower order IDs get earlier dates
sort( $dates );

return $dates;
}
}