Terms: Update description generator for new Faker behavior #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the new version of the Faker library introduced in #147, the behavior of the `realTextBetween` seems to have changed, making it more strict in its interpretation of the input parameters. This change avoids fatal errors by ensuring that there is always a range of 40 between the specified minimum number of characters and the maximum, so that the generator can always build a string with a length that falls somewhere within the range.
jorgeatorres
approved these changes
Dec 31, 2024
Member
jorgeatorres
left a comment
jorgeatorres
left a comment
There was a problem hiding this comment.
LGTM. Thank you @coreymckrill!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
With the new version of the Faker library introduced in #147, the behavior of the
realTextBetweenseems to have changed, making it more strict in its interpretation of the input parameters. This change avoids fatal errors by ensuring that there is always a range of 40 between the specified minimum number of characters and the maximum, so that the generator can always build a string with a length that falls somewhere within the range.Fixes #153
How to test the changes in this Pull Request:
nvm use && npm run setupwp wc generate terms product_cat 100and observe the fatal error (there are two different ones you might see, as described in the linked issue). You may have to run it a few times before you get an error.Changelog entry