Fixed get_random_device_type() output to match OrderAttributionMeta::get_device_type() possible return value.

[rawdreeg]

All Submissions:

• Have you followed the Contributing guidelines?
• Does your code follow the WordPress' coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

1. Fixed get_random_device_type() output to match OrderAttributionMeta::get_device_type() possible return value.
2. Fixed small PHP warnings.

How to test the changes in this Pull Request:

1. Using this branch, generate at least 500 orders
2. Follow the steps to test Woo Analytics Order Attribution reports ( https://woocommercep2.wordpress.com/2024/12/03/order-attribution-reports-hpos-and-non-hpos-support-internal-call-for-testing/#how-do-i-test)
3. Once connected, review the report, filter by Device, and confirm there is no know "Unknown" grouping

Before this PR:

After this PR:

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you successfully run tests with your changes locally?

Changelog entry

Fix - Remove unknown from get_random_device_type() output.

FOR PR REVIEWER ONLY:

• I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

[ibndawood]

Thank you, @rawdreeg, for the changes. I was able to test the PR with 500 orders and there were no Unknown devices in the generated orders.

[budzanowski]

How is Unsigned grouping generated?

[ibndawood]

The Unassigned grouping is made in the OA Reports API. This is per the Channel definitions described here: https://support.google.com/analytics/answer/9756891

Unassigned is the value Analytics uses when there are no other channel rules that match the event data.

(other) is the value Analytics uses for an aggregated row due to cardinality limits. Learn more