Skip to content

Conversation

@dlorenc
Copy link
Member

@dlorenc dlorenc commented Apr 2, 2023

Fixes: #952

Related:

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates

@dlorenc dlorenc requested a review from a team as a code owner April 2, 2023 18:08
@dlorenc dlorenc requested review from jdolitsky and kaniini April 2, 2023 18:08
@dlorenc
Copy link
Member Author

dlorenc commented Apr 2, 2023

Hey @klutchell - I gave this a try! It builds, could you double check the configure options I used?

@dlorenc dlorenc force-pushed the unbound branch 2 times, most recently from 464ec8c to 40c626a Compare April 2, 2023 18:17
@klutchell
Copy link

That was fast! I'll take a closer look this week but what about adding --enable-dnycrypt with libsodium?
https://github.com/buildroot/buildroot/blob/a45f2af7fae09e4daee9d017b02e8744b357cf48/package/unbound/unbound.mk#L45-L50

@klutchell
Copy link

Is there a way I can test what is produced before merging?

@dlorenc
Copy link
Member Author

dlorenc commented Apr 2, 2023

That was fast! I'll take a closer look this week but what about adding --enable-dnycrypt with libsodium? https://github.com/buildroot/buildroot/blob/a45f2af7fae09e4daee9d017b02e8744b357cf48/package/unbound/unbound.mk#L45-L50

Got it tacked on and it still builds!

@dlorenc
Copy link
Member Author

dlorenc commented Apr 2, 2023

Is there a way I can test what is produced before merging?

I can toss this into an image on ghcr somewhere and send it over!

@dlorenc
Copy link
Member Author

dlorenc commented Apr 2, 2023

You can try it at ghcr.io/dlorenc/unbound, I only have an arm64 build though.

@klutchell
Copy link

You can try it at ghcr.io/dlorenc/unbound, I only have an arm64 build though.

I don't seem to have read access to this.

@dlorenc
Copy link
Member Author

dlorenc commented Apr 3, 2023

You can try it at ghcr.io/dlorenc/unbound, I only have an arm64 build though.

I don't seem to have read access to this.

Hmm, it's marked as public:
image

I think I know - the tag is latest-arm64 instead of latest. Could you try ghcr.io/dlorenc/unbound:latest-arm64

@klutchell
Copy link

LGTM

Signed-off-by: Dan Lorenc <[email protected]>
@jdolitsky jdolitsky merged commit 653195a into wolfi-dev:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Wolfi Package Request]: Unbound

3 participants