rename the k8s csi external snapshotter to match the other k8s csi pa… #2246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
requested changes
May 22, 2023
Member
imjasonh
left a comment
imjasonh
left a comment
There was a problem hiding this comment.
Let's update the subpackages too
Contributor
Author
|
done. should we get all the other instances of k8s-csi packages into this PR as well? |
Member
|
Yeah anything else you think we should include |
Signed-off-by: Patrick Flynn <[email protected]>
patflynn
force-pushed
the
rename-kubernetes-csi-external-snapshotter
branch
from
d9ca76c to
d1a7eb4
Compare
Contributor
Author
|
@imjasonh good to dismiss request changsed? |
imjasonh
approved these changes
May 23, 2023
developer-guy
approved these changes
May 23, 2023
Member
|
eventually, we should rebuild the images as well to be able to use new package names, right? Will you do this @patflynn or I can do this for you WDYT? |
Member
|
I'm going to work on the kubernetes-csi-external-snapshotter images for both public (latest) and private (6.0.1), I need this one to be merged first 😁 |
Contributor
Author
|
@developer-guy 👍 we need to update the images too. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.