-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
FIX for adafruit portal S3: remove extra flash section #5113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated the Adafruit MatrixPortal ESP32-S3 board JSON to change partitions, rename the board to a WLED-specific variant, and remove the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@DedeHai good idea, I was also thinking maybe the "extra image" might be harmful because there is no space reserved for this in the non-UF2 partitions.csv.
Maybe we just change it to the "normal 8MB arduino-esp32 partition" file - I would better not remove this part completely. All board manifests have a partitions entry, and usually they are too small or they use FAT32 so wled will not work any way when users forget to set build.partitions. even the "default_partitions" set in [env] (or was is another section? Not sure atm) will be better than the default used in most board.json manifest files. |
softhack007
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just change the "partitions", everything else looks good for me.
plus minor name adjustment (adding "for WLED")
softhack007
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DedeHai all done, ready to merge.
|
perfect, thanks. I have been busy working on something else, I will ping you in a moment. |
…WLED partitions (wled#5113) * remove extra flash section, rename board file * matrixportal: change partitions to standard 8MB plus minor name adjustment (adding "for WLED") Co-authored-by: Frank <[email protected]>
@softhack007 should we also remove the
from the files build section? Reasoning: if a user's env does not specify partitions, it will still compile but with wrong partitioning.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.