bus_wrapper: Use parallel I2S first when enabled #4762

willmmiles · 2025-07-09T14:38:36Z

On ESP32, if parallel I2S is enabled, use it first, before selecting RMT outputs. This provides a quick workaround for RMT output issues (#4389), though it doesn't warn about #4315.

Summary by CodeRabbit

Bug Fixes
- Improved compatibility for ESP32 devices when using parallel I2S output, ensuring correct channel mapping and bus selection for various ESP32 variants.

coderabbitai · 2025-07-09T14:39:00Z

Walkthrough

The update modifies the internal logic of the PolyBus class in bus_wrapper.h. It adds conditional handling for channel remapping when using parallel I2S output on ESP32 (excluding ESP32-C3) and adjusts how the offset is determined in the getI method for various ESP32 variants. No public interfaces are changed.

Changes

File(s)	Change Summary
wled00/bus_wrapper.h	Added conditional channel remapping for ESP32 parallel I2S output; revised offset logic in getI method for ESP32-S2, ESP32-S3, and ESP32.

Suggested reviewers

blazoncek

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6199018 and 9569ec7.

📒 Files selected for processing (1)

wled00/bus_wrapper.h (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

wled00/bus_wrapper.h

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)

GitHub Check: wled_build / Build Environments (esp32dev_V4)
GitHub Check: wled_build / Build Environments (usermods)
GitHub Check: wled_build / Build Environments (esp32_wrover)
GitHub Check: wled_build / Build Environments (esp32s3_4M_qspi)
GitHub Check: wled_build / Build Environments (esp32s3dev_8MB_opi)
GitHub Check: wled_build / Build Environments (esp32s3dev_16MB_opi)
GitHub Check: wled_build / Build Environments (esp32c3dev)
GitHub Check: wled_build / Build Environments (esp8266_2m_compat)
GitHub Check: wled_build / Build Environments (lolin_s2_mini)
GitHub Check: wled_build / Build Environments (esp8266_2m)
GitHub Check: wled_build / Build Environments (esp32_eth)
GitHub Check: wled_build / Build Environments (nodemcuv2)
GitHub Check: wled_build / Build Environments (esp01_1m_full)
GitHub Check: wled_build / Build Environments (esp8266_2m_160)
GitHub Check: wled_build / Build Environments (nodemcuv2_compat)
GitHub Check: wled_build / Build Environments (esp01_1m_full_compat)
GitHub Check: wled_build / Build Environments (esp32dev)
GitHub Check: wled_build / Build Environments (esp01_1m_full_160)
GitHub Check: wled_build / Build Environments (nodemcuv2_160)
GitHub Check: wled_build / Test cdata.js

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

- helps with #4315 - add-on to #4762 - increases parallel I2S LED limit to 600 per bus

blazoncek

Fine, just update comments to reflect actual behaviour.

wled00/bus_wrapper.h

blazoncek · 2025-07-09T20:32:04Z

IMO this should also go into 0_15_x branch

netmindz · 2025-07-10T22:53:50Z

Unfortunately it won't cherry-pick without some conflict resolution, so I have not merged into 0_15_x

Are you able to cherry-pick and resolve @willmmiles ?

Arcitec · 2025-07-10T23:11:18Z

@netmindz I've cherry picked and rebased the fix to 0.15.x here: #4766

Thank you Will! If I understand correctly, these changes makes WLED prefer Parallel I2S instead of RMT to avoid the RMT flickering issues. I see that it selects offset 1 (I2S) when the channel number num is 0 - 7. So if the channel number is 8 or higher, it would use offset 0 (RMT).

In other words, it seems like everyone will be on Parallel I2S output mode now unless they have 9 or more channels, after which the last channels will start using RMT?

Good change! 👍

- helps with wled#4315 - add-on to wled#4762 - increases parallel I2S LED limit to 600 per bus

bus_wrapper: Use parallel I2S first when enabled

6199018

netmindz added this to the 0.15.1 Bugfix release milestone Jul 9, 2025

blazoncek added a commit that referenced this pull request Jul 9, 2025

Prevent parallel I2S use if different LED types are used.

1808fa7

- helps with #4315 - add-on to #4762 - increases parallel I2S LED limit to 600 per bus

blazoncek mentioned this pull request Jul 9, 2025

Prevent parallel I2S use if different LED types are used. #4763

Merged

blazoncek approved these changes Jul 9, 2025

View reviewed changes

wled00/bus_wrapper.h Outdated Show resolved Hide resolved

wled00/bus_wrapper.h Outdated Show resolved Hide resolved

bus_wrapper: Update comments to reflect RMT usage

9569ec7

netmindz merged commit 8bcd455 into wled:main Jul 10, 2025
21 checks passed

This was referenced Jul 10, 2025

No blue rendered on WS2814 with parallel I2S on 0.15.0 #4719

Closed

(0.15.x backport) bus_wrapper: Use parallel I2S first when enabled #4766

Merged

Pluto1010 pushed a commit to Pluto1010/WLED that referenced this pull request Sep 1, 2025

Prevent parallel I2S use if different LED types are used.

0b6cd2b

- helps with wled#4315 - add-on to wled#4762 - increases parallel I2S LED limit to 600 per bus

coderabbitai bot mentioned this pull request Sep 14, 2025

Fix LED buffer size calculation #4928

Merged

coderabbitai bot mentioned this pull request Sep 21, 2025

fix buffer size calculation for ESP8266 (0.15 edition) #4951

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

bus_wrapper: Use parallel I2S first when enabled #4762

bus_wrapper: Use parallel I2S first when enabled #4762

willmmiles commented Jul 9, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 9, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

blazoncek left a comment

Uh oh!

Uh oh!

Uh oh!

blazoncek commented Jul 9, 2025

Uh oh!

Uh oh!

netmindz commented Jul 10, 2025

Uh oh!

Arcitec commented Jul 10, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

bus_wrapper: Use parallel I2S first when enabled #4762

bus_wrapper: Use parallel I2S first when enabled #4762

Conversation

willmmiles commented Jul 9, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

blazoncek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

blazoncek commented Jul 9, 2025

Uh oh!

Uh oh!

netmindz commented Jul 10, 2025

Uh oh!

Arcitec commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

willmmiles commented Jul 9, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 9, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

Arcitec commented Jul 10, 2025 •

edited

Loading