-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
add inverse gamma 32 function and fix colors in pride #4722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes introduce an inverse gamma correction method for 32-bit RGBW colors and update the color blending logic in the pride effect to use this correction. The default gamma value in configuration is adjusted from 2.8 to 2.2. A macro and method for inverse gamma correction are added to the relevant class and header. Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (19)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
blazoncek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have chosen a slightly different method/function names (i.e. inverseGama32() or revertGamma32()) but otherwise looks ok to me.
* add inverse gamma 32 function and fix for colors in pride
more FX that do not use palettes may need gamma inversion as well so adding a function to do that.
Summary by CodeRabbit
New Features
Bug Fixes
Chores