fixed wrong gravity setting, added option for no trail

[DedeHai]

Summary by CodeRabbit

• Improvements
  • Enhanced the particle fireworks effect with more dynamic gravity, rocket timing, and explosion visuals.
  • Explosion particle size now varies based on intensity settings.
  • Added clearer effect descriptions, including new "Colorful" and "Trail" options.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes focus exclusively on the mode_particleFireworks1D function within the FX.cpp file. Updates include clarifying comments, adjusting the logic for gravity calculation, modifying rocket timing parameters, and altering how explosion particle sizes and colors are determined. The effect's metadata string was also revised to reflect new parameters and option flags. No changes were made to the declarations or signatures of any exported or public entities.

Changes

Files	Change Summary
wled00/FX.cpp	Updated comments, revised gravity logic, changed rocket life timing, randomized explosion size based on intensity, adjusted color mode condition, and updated effect metadata string.

Possibly related PRs

• Updates to particle system #4630: Modifies the same mode_particleFireworks1D function, specifically focusing on particle velocity and saturation calculations, indicating a direct code-level connection.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.31.1)

wled00/FX.cpp

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a4feeb9 and 98b214a.

📒 Files selected for processing (1)

• wled00/FX.cpp (5 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

wled00/FX.cpp (1)

9387-9387: Separated colorful mode flag from trail option.

The condition for colorful mode now uses SEGMENT.check1 instead of SEGMENT.check2, which properly separates these features. This allows users to independently control both the colorful mode and trail options.

There's a small typo in the comment: "colorufl" should be "colorful".

-        if (SEGMENT.check1) // colorufl mode
+        if (SEGMENT.check1) // colorful mode

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 410025f and a4feeb9.

📒 Files selected for processing (1)

• wled00/FX.cpp (5 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (18)

• GitHub Check: wled_build / Build Environments (usermods)
• GitHub Check: wled_build / Build Environments (esp32_wrover)
• GitHub Check: wled_build / Build Environments (esp32c3dev)
• GitHub Check: wled_build / Build Environments (esp32s3dev_8MB_opi)
• GitHub Check: wled_build / Build Environments (esp32s3dev_16MB_opi)
• GitHub Check: wled_build / Build Environments (esp32s3_4M_qspi)
• GitHub Check: wled_build / Build Environments (esp32_eth)
• GitHub Check: wled_build / Build Environments (esp32dev_V4)
• GitHub Check: wled_build / Build Environments (lolin_s2_mini)
• GitHub Check: wled_build / Build Environments (esp32dev)
• GitHub Check: wled_build / Build Environments (esp01_1m_full_compat)
• GitHub Check: wled_build / Build Environments (esp8266_2m)
• GitHub Check: wled_build / Build Environments (esp01_1m_full_160)
• GitHub Check: wled_build / Build Environments (nodemcuv2_160)
• GitHub Check: wled_build / Build Environments (nodemcuv2)
• GitHub Check: wled_build / Build Environments (nodemcuv2_compat)
• GitHub Check: wled_build / Build Environments (esp01_1m_full)
• GitHub Check: wled_build / Build Environments (esp8266_2m_160)

🔇 Additional comments (5)

wled00/FX.cpp (5)

9311-9311: LGTM - comment clarification.

The comment update clarifies that this is an advanced particle system.

---

9327-9328: Fixed gravity calculation.

The gravity calculation has been improved by separating the computation and conditional application. This fixes the issue mentioned in the PR title and makes the code more readable.

---

9343-9344: Improved rocket lifetime parameters for trail option.

The changes reduce the minimum lifetime from 100 to 30 and make the maximum lifetime conditional:

• When trail option is enabled (SEGMENT.check2): 400 (longer trail)
• When trail option is disabled: 40 (shorter/no trail)

This directly addresses the PR objective "added option for no trail".

---

9383-9383: Dynamic particle size based on intensity.

Changed from a fixed size of 64 to a randomized size based on SEGMENT.intensity, which allows more variation and control over the visual effect.

---

9407-9407: Updated effect metadata for new options.

The metadata string was updated to include "Colorful" and "Trail" parameters, with corresponding option flags (o1=1,o2=1). This properly documents the new functionality added to the effect.