UserModManager only call enabled UserMods #4475
Draft
+58
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netmindz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a partially implemented concept of a usermod being enabled or disabled, but we leave it to every single usermod to try and write this themselves and ensure proper checks are in place to prevent execution of code when not actually enabled and also issues like being called before they have actually been initialised.
This results in lots of usermod methods needing to start wth
if(!enabled) returnThis PR tries to clean this up so we maintain a list of actually which usermod are enabled so we don't keep calling
loop()on disabled usermods and aims to making usermods easier by moving common logic into the UserModManager