Usermod F-string hygiene #4223
Merged
Usermod F-string hygiene #4223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since oappend() is now strongly typed, pass the correct type. This is a step towards removing the extra shim logic on ESP8266.
Collaborator
|
IMO both are good. The other one will prevent misuse in the future. |
blazoncek
approved these changes
Oct 24, 2024
Collaborator
blazoncek
left a comment
blazoncek
left a comment
There was a problem hiding this comment.
Has a go from my side.
Member
|
Thanks 👍 should be merged as it's a critical bugfix for 8266. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another missing remnant of the end-oappend work: migrating usermods to use F() instead of F_STR() so as to pass the FlashStringHelper type along to the print() layer. Usermods calling
oappend(F_STR("")on ESP8266 will crash without the shim in #4222. This could be considered an alternative fix: correct the source, rather than provide a workaround at a runtime cost.