Fixed the positioning of the "Download the latest binary" button #4184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxi4329
changed the title
maxi4329
changed the title
netmindz
approved these changes
Oct 7, 2024
softhack007
pushed a commit
to MoonModules/WLED-MM
that referenced
this pull request
Oct 11, 2024
…d#4184) * fixed the positioning of the download button * fixed space after "Download the latest binary:" disapering after building * fixed typo --------- Co-authored-by: maxi4329 <maxi4329>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects the positioning of the "Download the latest binary" button on the
update.htmpage, where the button was slightly misaligned above the text.The issue was resolved by using
vertical-align: text-bottom;.Additionally, the alignment of the
<a>tag with the<img>inside it has been improved by applyingdisplay: inline-flex;(see comparison images below).
before:
after:
Edit: Fixed the issue where the space after "Download the latest binary:" disappeared after building by adding
.