Skip to content

Conversation

@netmindz
Copy link
Member

@netmindz netmindz commented Jul 15, 2024

Following on from this PR #4056

Replace convoluted logic in settings_leds.htm with config requirements supplied in the LEDType data

Motivation - #3777

@blazoncek
Copy link
Collaborator

blazoncek commented Aug 22, 2024

@netmindz please take a look at 6f3267a
Implements similar as this PR but does not change Bus class. Instead it utilises BusManager and uses LED type convention to select appropriate GPIO text.

EDIT: There are other (mostly) irrelevant changes throughout bus_manager files to improve readability and optimise code.

@blazoncek
Copy link
Collaborator

Except for GPIO field names I think this PR has become obsolete.
Will you expand on GPIO or move that into HUB75 PR? I would prefer latter.

@netmindz
Copy link
Member Author

I'll still like to remove things like IP address from the html, but certainly anything in here needs to be redone against the final bus-config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants