UM Audioreactive: add two compiler options #3732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Actually I'd call it "dynamics limiter" instead of rise-fall-limiter. Otherwise OK for me 👍 |
Contributor
Author
|
Good point, renamed to UM_AUDIOREACTIVE_DYNAMICS_LIMITER_OFF |
softhack007
approved these changes
Jan 31, 2024
blazoncek
added a commit
that referenced
this pull request
Feb 1, 2024
UM Audioreactive: add two compiler options
softhack007
pushed a commit
to MoonModules/WLED-MM
that referenced
this pull request
Feb 12, 2024
UM Audioreactive: add two compiler options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two additional compiler options:
UM_AUDIOREACTIVE_ENABLE: makes usermod default enabled
UM_AUDIOREACTIVE_DYNAMICS_LIMITER_OFF: disables rise/fall limiter default