Fix bug that welcome page was not shown #3606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aircoookie
approved these changes
Dec 22, 2023
Member
Aircoookie
left a comment
Aircoookie
left a comment
There was a problem hiding this comment.
Good catch! This is due to initConnection() no longer returning at AP init if WiFi is not configured as ESP-NOW init is also part of the function now. Your fix should do the trick just fine.
w00000dy
added a commit
to w00000dy/WLED
that referenced
this pull request
Jan 3, 2024
commit bd20c83 Author: Blaz Kristan <[email protected]> Date: Mon Jan 1 23:14:45 2024 +0100 Bugfix wled#3632 commit 48f8a45 Author: Blaz Kristan <[email protected]> Date: Sun Dec 31 18:05:21 2023 +0100 Last minute adjustments & fixes commit 680cec5 Author: Istvan Meszaros <[email protected]> Date: Tue Dec 26 11:09:20 2023 +0100 Make palette editor mobile friendly. commit ecdc3be Author: Blaz Kristan <[email protected]> Date: Sat Dec 30 11:56:21 2023 +0100 Changlog update commit 301bdf2 Merge: 1c1b67e d3be7a3 Author: Blaž Kristan <[email protected]> Date: Sat Dec 30 11:00:53 2023 +0100 Merge pull request wled#3610 from Aircoookie/psram-4-json Allow PSRAM (SPI RAM) to be used for JSON buffer commit 1c1b67e Author: Blaz Kristan <[email protected]> Date: Fri Dec 29 23:07:29 2023 +0100 Full per-port ABL implementation and bugfix. Update of BusManager class (static) commit d3be7a3 Merge: 7971f3c 6cd0da8 Author: Blaz Kristan <[email protected]> Date: Thu Dec 28 23:38:27 2023 +0100 Merge branch '0_15' into psram-4-json commit 6cd0da8 Author: Blaz Kristan <[email protected]> Date: Thu Dec 28 23:32:47 2023 +0100 Reduce heap fragmentation when switching ledmaps commit 6332ee6 Author: Blaz Kristan <[email protected]> Date: Wed Dec 27 19:36:25 2023 +0100 Effect buffer optimisations setMode() fix for selecting gap UI error messages commit 7971f3c Author: Blaz Kristan <[email protected]> Date: Sat Dec 23 22:56:07 2023 +0100 Fix for saving config. commit 08d9f7d Author: Blaz Kristan <[email protected]> Date: Sat Dec 23 21:05:01 2023 +0100 Fix for wled#2922 commit 776502e Merge: 4e10549 7af5b24 Author: Blaž Kristan <[email protected]> Date: Sat Dec 23 20:27:20 2023 +0100 Merge pull request wled#3606 from WoodyLetsCode/welcome Fix bug that welcome page was not shown commit 7af5b24 Author: Woody <[email protected]> Date: Thu Dec 21 22:17:43 2023 +0100 Fix bug that welcome page was not shown commit 1f81fb9 Author: Blaz Kristan <[email protected]> Date: Thu Dec 21 21:30:17 2023 +0100 Implement JSON buffer in PSRAM to free up DRAM. commit 4e10549 Author: Blaz Kristan <[email protected]> Date: Thu Dec 21 21:02:53 2023 +0100 Retry on failed JSON load. Throttle for ESP8266 This is a band-aid for ESP8266 JSON corruption and not a proper fix. commit abf7dd5 Merge: 6c877b6 37b8072 Author: Blaž Kristan <[email protected]> Date: Thu Dec 21 20:49:44 2023 +0100 Merge pull request wled#3587 from WoodyLetsCode/search-scroll-top Scroll to first search result on search commit 6c877b6 Merge: 42dba31 86d2998 Author: Blaž Kristan <[email protected]> Date: Thu Dec 21 20:43:29 2023 +0100 Merge pull request wled#3597 from WoodyLetsCode/inline Inline iro.js and rangetouch.js commit 86d2998 Author: Xaver <[email protected]> Date: Wed Dec 20 11:30:28 2023 +0100 Add reference to old loading of iro.js and rangetouch.js commit 201daf8 Author: Woody <[email protected]> Date: Tue Dec 19 22:40:24 2023 +0100 Remove /iro.js and /rangetouch.js commit 1140f5f Author: Woody <[email protected]> Date: Tue Dec 19 21:18:33 2023 +0100 Update version to 2312190 commit 0a91d60 Author: Woody <[email protected]> Date: Tue Dec 19 21:12:07 2023 +0100 add onload event to body commit 5cd8f56 Author: Woody <[email protected]> Date: Tue Dec 19 20:41:56 2023 +0100 Remove unused feedback function This was probably forgotten to remove in commit d6c0642 commit b2babd9 Author: Xaver <[email protected]> Date: Tue Dec 19 16:52:15 2023 +0100 inline iro.js and rangetouch.js commit 37b8072 Author: Woody <[email protected]> Date: Wed Dec 13 18:22:09 2023 +0100 Scroll to first search result on search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the welcome page was not shown anymore.
This is a fix for that.
Now the welcome page shows up again.