Allow more compile time settings for multi-relay #3498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Please re-base your PR to 0_14_1 or 0_15 branch. |
chrisburrows
force-pushed
the
multi-relay-settings
branch
from
6ddc1d6 to
94d754e
Compare
blazoncek
requested changes
Nov 7, 2023
Collaborator
blazoncek
left a comment
blazoncek
left a comment
There was a problem hiding this comment.
The C++ code is ok, but the changes in readme.md require some updates.
Please also add changelog at the end of readme (and include your info for future reference).
usermods/multi_relay/readme.md
Outdated
|
|
||
| Some settings can be defined (defaults) at compile time by setting the following defines: | ||
|
|
||
| MULTI_RELAY_HA_DISCOVERY true or false |
Collaborator
There was a problem hiding this comment.
These changes do not render correctly when viewed as a document (i.e. viewed on Github).
blazoncek
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change to allow more characteristics of the relays to be set at compile time. Useful if you have a standard hardware build / config across multiple WLED instances (e.g. always use the same pin for a relay).