Skip to content

Conversation

@Moustachauve
Copy link
Contributor

Add the information about which software branch, beta or stable, is being used on this device. This is accessible through both the JSON API and MQTT, just like the version string. This will automatically detect if it is a beta or not based on the release version configured in package.json to make sure it is always set properly.

This could be really useful for any consumer of the API that wants to make sure to check the correct channel to know potentially if a device is using the most recent version, for example and also to match it to the correct branch (beta, soundreactive, ...).

Add the information about which software branch, beta or stable, is being used on this device.
This is accessible through both the JSON API and MQTT, just like the version string.
This will automatically detect if it is a beta or not based on the release version configured in package.json to make sure it is always set properly.

This could be really useful for any consumer of the API that wants to make sure to check the correct channel to know potentially if a device is using the most recent version, for example and also to match it to the correct branch (beta, soundreactive, ...).
@softhack007 softhack007 added enhancement connectivity Issue regarding protocols, WiFi connection or availability of interfaces labels Sep 30, 2023
@blazoncek
Copy link
Contributor

It is a pity you used main branch as I can't pull into local repo.
Still, good though.

As a side note for @softhack007 and @Aircoookie we will need to start measuring /json/si size as there were a lot of additions lately and things may break on EPS8266 pretty soon.

@Moustachauve
Copy link
Contributor Author

I don't know what you mean by merge it in a "local" branch, but you can create a new pull request or edit the destination branch of this PR to point to another WLED branch.

@blazoncek
Copy link
Contributor

I don't know what you mean by merge it in a "local" branch, but you can create a new pull request or edit the destination branch of this PR to point to another WLED branch.

Any PR made to WLED repo can be checked out (by collaborators or owner) if it is made in a separate branch.

So, if you'd made i.e. "release-check" branch and made PR from that, I'd be able to check-out and test-drive it.

Please see https://github.com/Aircoookie/WLED/wiki/How-to-properly-submit-a-PR

@Moustachauve
Copy link
Contributor Author

I created #3407 to follow the guidelines as recommended per @blazoncek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

connectivity Issue regarding protocols, WiFi connection or availability of interfaces enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants