show current local time in info page ⏲️ #3351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please remove all (.h) files that have no connection with the PR. |
This reverts commit 2bf052a.
blazoncek
approved these changes
Aug 30, 2023
Contributor
blazoncek
left a comment
blazoncek
left a comment
There was a problem hiding this comment.
All good.
I would prefer shorter string instead of "Current local time". Perhaps just "Time"?
Contributor
Author
I would also prefer 'Time'. My initial idea was to keep it consistent with the 'Time & Macros' page. But if that is not important, then let's change it to 'Time' 👍 |
Contributor
Author
|
|
Member
|
Change looks ok for me, too. Would agree to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3284
Adding the current local time to the info page ⏲️ . This allows to check the device time quickly without having to navigate to the Time & Macros Settings page 🎉
Best,
Sandro