Buttons: Trigger on button press (instead of release) if all configured presets are the same

[Sebbb]

Hello,

this addresses #3189. It works well for me, but I'm not sure if it doesn't maybe need additional debouncing code with some switches.

[blazoncek]

Thank you.
Would you be so kind and also add the info (PR) about same presets causing such behaviour to WLED docs?

[softhack007]

maybe need additional debouncing code with some switches.

I think you're right here, a new debounce logic must be added in case that "button activation" is used as a trigger.

The current "trigger on release" logic applies debouncing before the release event. However with "trigger on activation", the problem will be that a single press is followed by several "ghost" activations and deactivations (typically within 100-300 milliseconds). It does not depend on the button type - both switches and momentary buttons do bounce before they settle in the final position.

So it seems that your optimization also requires a new debouncing logic, to be usefull in the general case.

https://en.m.wikipedia.org/wiki/Switch#Contact_bounce

[Sebbb]

Hi,

I never experienced issues with that, for me it works perfectly reliable. Maybe because that button check routine is only executed every few milliseconds (?) to check the button state and does not trigger an interrupt.

However, I'm definitely not a good programmer and probably wouldn't be able to add that, if it's needed :(

Sebastian

[Aircoookie]

Added a slightly hacky debounce logic, should work fine though.
On release it only reset buttonPressedBefore after 50 ms of uninterrupted released, and thus block further presses until the button has been released properly.

[softhack007]

Added a slightly hacky debounce logic,

Thanks @Aircoookie, I think this will do the trick 👍

[Sebbb]

@Aircoookie I just compiled and tried your changes, works well :)