Skip to content

Conversation

@blazoncek
Copy link
Contributor

Up to 4 segment groups can be defined.
Visible only when more than 2 segments are created and has no other functionality other than allowing quick segment selection in UI.

NOTE: Reduces possible audio simulations from 8 to 2 (keeping BeatSin and WeWillRockYou) to accommodate segment groups without increasing Segment RAM footprint.

@blazoncek blazoncek changed the title Add support for segment groupping Add support for segment grouping Apr 11, 2023
@blazoncek blazoncek requested a review from Aircoookie April 12, 2023 13:16
@blazoncek
Copy link
Contributor Author

@Aircoookie would you agree with adding segment groups?

@Aircoookie
Copy link
Member

This feature sound interesting, will finally check it out soon!
Two points in advance:

  • Maybe we should name this feature segment set/bunch/cluster/collection so it won't be confused with the Grouping grp property
  • Not a fan of cutting sound simulation modes, was rather hoping to add more in the future. Keeping the existing RAM footprint is good too though. I would keep the extra simulation modes commented out for now and we can consider expanding the segment options flag union to 32 bit in the future.

@blazoncek
Copy link
Contributor Author

As sound (if used from microphone) affects all segments equally I would rather see a global sound simulation option instead of per-segment one.

With such approach the implementation with 1 bit could mean 0 use simple beatsin (per segment) and 1 use global.

And honestly stuffing more simulation options could be done in usermod.

@blazoncek
Copy link
Contributor Author

I agree on name change so instead of segment groups we can use segment sets.

@blazoncek blazoncek changed the title Add support for segment grouping Add support for segment sets (groups of segments) May 15, 2023
@blazoncek
Copy link
Contributor Author

@Aircoookie any chance to give this another try?
I have plenty of bugfixes queued. Waiting for this PR to be merged or rejected.

Fix repeat segment button remaining hidden
Fix third segment row (offset) alignment in 1D mode
Keep disabled sound simulation modes as comment for reference
New local var for 2D seg UI, improves code legibility
Copy link
Member

@Aircoookie Aircoookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to be merged! (finally, sorry it took so long)
Ideally the g-icon would also show in expanded segment view (though the only place I see that would be available is above the delete button), though this does not have to be added immediately.

@blazoncek blazoncek merged commit 926e9ff into main May 30, 2023
@blazoncek blazoncek deleted the seg-groups branch May 30, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants