-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Add support for segment sets (groups of segments) #3171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sacrificed 1 bit on sound simulation and 1D to 2D mapping each.
|
@Aircoookie would you agree with adding segment groups? |
|
This feature sound interesting, will finally check it out soon!
|
|
As sound (if used from microphone) affects all segments equally I would rather see a global sound simulation option instead of per-segment one. With such approach the implementation with 1 bit could mean 0 use simple beatsin (per segment) and 1 use global. And honestly stuffing more simulation options could be done in usermod. |
|
I agree on name change so instead of segment groups we can use segment sets. |
|
@Aircoookie any chance to give this another try? |
Fix repeat segment button remaining hidden Fix third segment row (offset) alignment in 1D mode Keep disabled sound simulation modes as comment for reference New local var for 2D seg UI, improves code legibility
Aircoookie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to be merged! (finally, sorry it took so long)
Ideally the g-icon would also show in expanded segment view (though the only place I see that would be available is above the delete button), though this does not have to be added immediately.
Up to 4 segment groups can be defined.
Visible only when more than 2 segments are created and has no other functionality other than allowing quick segment selection in UI.
NOTE: Reduces possible audio simulations from 8 to 2 (keeping BeatSin and WeWillRockYou) to accommodate segment groups without increasing
SegmentRAM footprint.