Add colorUpdated call #2236
Merged
Add colorUpdated call #2236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blazoncek
reviewed
Sep 29, 2021
| handleSet(nullptr, cmdStr, false); | ||
| } | ||
| } | ||
| colorUpdated(CALL_MODE_BUTTON); |
Contributor
There was a problem hiding this comment.
Doesn't this belong to a line above closing brace? Immediately after handleSet().
Contributor
Author
There was a problem hiding this comment.
It is there because it needs called for incBrightness, decBrightness also. I haven’t tested it. But I think we could remove it here, add it after each of those calls and pass apply=true to handleSet if you prefer. However, doing so may not sync to other nodes.
Contributor
There was a problem hiding this comment.
No, no.
Thanks for clarifying. It makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After AC refactored, changes in brightness and on/off using "&T=" don't work.
See issue #2231