Use RFC 2119's keywords (MUST, MAY, ...) #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@wking just need one minor fix see above. |
Owner
Author
|
On Fri, Dec 11, 2015 at 08:39:43AM -0800, W. Trevor King wrote:
And I just pushed 6f5ae34 → be67069, resolving a conflict with the |
This approach has landed in opencontainers/specs [1,2]. You can find the RFC here [3]. [1]: opencontainers/runtime-spec#256 [2]: opencontainers/runtime-spec#260 [3]: http://tools.ietf.org/html/rfc2119 Signed-off-by: W. Trevor King <[email protected]> Reviewed-by: Mike Brown <[email protected]>
Owner
Author
|
On Fri, Dec 11, 2015 at 05:04:58PM -0800, W. Trevor King wrote:
Merged with a @mikebrow Signed-off-by, since I fixed the typo he |
wking
added a commit
that referenced
this pull request
Jun 22, 2016
These slipped through e41ffc1 (Use RFC 2119's keywords (MUST, MAY, ...), 2015-12-02, #9). Signed-off-by: W. Trevor King <[email protected]>
wking
added a commit
that referenced
this pull request
Jul 5, 2016
These slipped through e41ffc1 (Use RFC 2119's keywords (MUST, MAY, ...), 2015-12-02, #9). Signed-off-by: W. Trevor King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec landed an RFC 2119 approach in opencontainers/runtime-spec#260.
There is already some discussion on a previous version of this commit
here, as well as some related RFC 2119 work in #8.