Skip to content

Bump bitbox api version#112

Merged
edouardparis merged 2 commits intomasterfrom
bump-bitbox-api-version
Jul 21, 2025
Merged

Bump bitbox api version#112
edouardparis merged 2 commits intomasterfrom
bump-bitbox-api-version

Conversation

@edouardparis
Copy link
Copy Markdown
Member

No description provided.

@sdmg15
Copy link
Copy Markdown
Contributor

sdmg15 commented Jul 20, 2025

Hello,
Thanks for this library.
I'm currently working on this PR from BDK bitcoindevkit/bdk_wallet#206 and I was exactly about to open an issue to request for bitbox-api bumping thankfully you did it before.

But I have another request, bitbox-api offers simulator feature, and it could be useful for people doing tests outside of physical devices. I'm using also using that feature in my PR. If you could enable it also on async-hwi so that people that depend on it can enable/disable it at will like other features it'll great.
Thanks.

@edouardparis
Copy link
Copy Markdown
Member Author

But I have another request, bitbox-api offers simulator feature, and it could be useful for people doing tests outside of physical devices. I'm using also using that feature in my PR. If you could enable it also on async-hwi so that people that depend on it can enable/disable it at will like other features it'll great.
Thanks.

Sure, can you open an issue. We will bump the library version right after merging this PR because we are a little pressed by time but we can definitely look into that after.

@edouardparis edouardparis merged commit 8454bf0 into master Jul 21, 2025
1 of 2 checks passed
@edouardparis edouardparis deleted the bump-bitbox-api-version branch July 21, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants