Add support for multiple modals on top of eachother

[talkol]

Right now we only support one modal at any given time

The API should remain the same, dismissModal should dismiss the topmost modal

[siwymilek]

@talkol what do you think to add passing props to modal?

[talkol]

@siwymilek that's a good point..

Currently the show modal is a very low level function that takes a controller and displays it. A controller doesn't accept props. It has its own JSX definition where we can pass props directly to its children. But that's not very convenient because this means you need to define JSX on the fly for every new modal you have if they each have different props.

That's actually what happens in https://github.com/wix/react-native-navigation
If you'll look at the docs you'll see that the react-native-navigation does allow you to send props to modals and that's exactly how it's implemented. Just a higher level of abstraction over the low level interface

I'm worried that adding props to the original low level function will complicate it.. what do you think? are you using controllers directly or through navigation?

[siwymilek]

@talkol I'm sorry but I don't understand what you mean of "using controllers directly or through navigation"

[talkol]

@siwymilek see this:
https://github.com/wix/react-native-controllers#before-you-start

"react-native-controllers is a low-level package with API that wasn't designed to be cross-platform (since it's optimized for native UX). We have another project called react-native-navigation which is a syntactic sugar wrapper around react-native-controllers. It provides the same native goodness with API that is much simpler, cross-platform between iOS and Android, and supports redux!"

I meant to ask if you're using react-native-controllers or the react-native-navigation wrapper

[siwymilek]

@talkol I use react-native-controllers

[talkol]

@artald added multiple modal support.
Leaving the issue open until we address @siwymilek request for props

[artald]

@talkol I think we should close this one and open a separate issue for the props. They are not related in any way.

[talkol]

Sure, @artal do you mind closing and opening a new issue?

On Friday, 25 March 2016, Artal Druk notifications@github.com wrote:

@talkol https://github.com/talkol I think we should close this one and
open a separate issue for the props. They are not related in any way.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#26 (comment)

[artald]

np.
Multiple modals closed with ffdcda2.
New issue for passing props to modal is here.

[talkol]

@siwymilek the next release will include support for passing props to modals