New island example #1807
Merged
New island example #1807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarah11918
reviewed
Oct 18, 2022
Co-authored-by: Sarah Rainsberger <[email protected]>
sarah11918
reviewed
Oct 18, 2022
src/pages/en/tutorial/6-islands/1.md
Outdated
| || **Same**: They both show the same HTML elements and look the same initially. Different: The component with the `client:load` directive will rerender after the page is loaded, and any interactive elements that it has will work. || | ||
| 3. If you couldn't see your website's code, only the live published page, how would you tell which `<SvelteCounter />` component used `client:visible`? | ||
| 3. Assume the `SvelteCounter` component shows a number and has a button to increase it. If you couldn't see your website's code, only the live published page, how would you tell which of the two `<SvelteCounter />` component used `client:load`? |
Member
There was a problem hiding this comment.
If you want to change this to client:load then be sure to change it in the code sample too! It doesn't look like that was changed.
Contributor
Author
There was a problem hiding this comment.
Oops, I'd experimented with that, but decided to keep it the way it is! Fixed
Member
There was a problem hiding this comment.
Did you fix this? It didn't change here. 😅
Contributor
Author
There was a problem hiding this comment.
🤦 should be changed now!
Member
|
LGTM Dan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, removed the second Preact example and made the first one interactive with a button.