Skip to content

Fix an issue where ReadableStream wasn't canceled in dev mode#9971

Merged
ematipico merged 3 commits intowithastro:mainfrom
mingjunlu:fix/cancel-readable-stream-in-dev-mode
Feb 13, 2024
Merged

Fix an issue where ReadableStream wasn't canceled in dev mode#9971
ematipico merged 3 commits intowithastro:mainfrom
mingjunlu:fix/cancel-readable-stream-in-dev-mode

Conversation

@mingjunlu
Copy link
Contributor

@mingjunlu mingjunlu commented Feb 4, 2024

Changes

Testing

Docs

  • N/A

@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2024

🦋 Changeset detected

Latest commit: bc1c161

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 4, 2024
Copy link
Contributor

@lilnasy lilnasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks for the clean fix!

@ematipico ematipico merged commit d9266c4 into withastro:main Feb 13, 2024
@astrobot-houston astrobot-houston mentioned this pull request Feb 13, 2024
@mingjunlu mingjunlu deleted the fix/cancel-readable-stream-in-dev-mode branch February 13, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReadableStream in response body not canceled when client closes connection (in dev mode)

4 participants