feat: resolve images through the file systems on applicable runtimes#8698
Merged
Princesseuh merged 3 commits intomainfrom Sep 29, 2023
Merged
feat: resolve images through the file systems on applicable runtimes#8698Princesseuh merged 3 commits intomainfrom
Princesseuh merged 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 06d6b84 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: integration
Princesseuh
changed the title
matthewp
approved these changes
Sep 28, 2023
Merged
ematipico
pushed a commit
that referenced
this pull request
Feb 5, 2025
…8698) * feat: add a node image endpoint * test: fix
ematipico
pushed a commit
that referenced
this pull request
Feb 5, 2025
…8698) * feat: add a node image endpoint * test: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This adds a Node specific image endpoint that we can use in both dev and Node SSR (only Node adapter right now, could be expanded). On other platforms, we fallback to the same endpoint as before.
Fix #8395
Fix #6128
Fix #5699
Not sure if it also works for #7974, since I cannot reproduce that one. It might though!
Testing
Tests should all pass! I also tested the Node adapter locally and it worked.
Docs
N/A