Remove AstroError if content directory is empty#8382
Merged
ematipico merged 6 commits intowithastro:mainfrom Sep 21, 2023
DerTimonius:fix/empty-collection-dir-error
Merged
Remove AstroError if content directory is empty#8382ematipico merged 6 commits intowithastro:mainfrom DerTimonius:fix/empty-collection-dir-error
ematipico merged 6 commits intowithastro:mainfrom
DerTimonius:fix/empty-collection-dir-error
Conversation
🦋 Changeset detectedLatest commit: ef8269e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
1 task
Member
|
Any news on this? Maybe you can mark it as ready and you'll get reviews about the changeset etc? |
Contributor
Author
|
I wanted to wait for initial feedback, since I was not sure if I'm on the right track here, but I'll mark it as ready for review |
ematipico
reviewed
Sep 12, 2023
ematipico
reviewed
Sep 12, 2023
…us/astro into fix/empty-collection-dir-error
ematipico
approved these changes
Sep 20, 2023
Member
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
I believe we can merge this PR, once rebased
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
AstroErroringetCollectionif the targeted content directory is emptyTesting
Added a new test in the
content-collection.test.js, currently work in progressDocs
Docs are unaffected by this change
Still Todo
Wanted to wait for some feedback before: