Skip to content

Handle error state for version#7939

Merged
natemoo-re merged 3 commits into
mainfrom
fix/create-astro-version
Aug 3, 2023
Merged

Handle error state for version#7939
natemoo-re merged 3 commits into
mainfrom
fix/create-astro-version

Conversation

@natemoo-re
Copy link
Copy Markdown
Member

Changes

  • We noticed that npm create astro sometimes printed vundefined, which is embarrasing
  • This adds an error handler to ensure that we don't print the version if the lookup fails

Testing

Manually. It works!

Docs

N/A

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 3, 2023

🦋 Changeset detected

Latest commit: b67100b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the pkg: create-astro Related to the `create-astro` package (scope) label Aug 3, 2023
@TheOtterlord
Copy link
Copy Markdown
Member

I can't leave a comment directly for this part of the file, but does this line also need updating?

Copy link
Copy Markdown
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@natemoo-re natemoo-re merged commit 89cd4b8 into main Aug 3, 2023
@natemoo-re natemoo-re deleted the fix/create-astro-version branch August 3, 2023 21:03
@astrobot-houston astrobot-houston mentioned this pull request Aug 3, 2023
ematipico pushed a commit that referenced this pull request Aug 4, 2023
* fix(create-astro): handle error state for version

* fix: handle missing version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: create-astro Related to the `create-astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants