Skip to content

Catch errors that occur within the stream in the Node adapter#6935

Merged
matthewp merged 4 commits intomainfrom
node-adapter-error
May 1, 2023
Merged

Catch errors that occur within the stream in the Node adapter#6935
matthewp merged 4 commits intomainfrom
node-adapter-error

Conversation

@matthewp
Copy link
Contributor

Changes

Testing

  • Test added

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2023

🦋 Changeset detected

Latest commit: 9620ab7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Apr 28, 2023
Copy link
Member

@MoustaphaDev MoustaphaDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matthewp matthewp merged commit c405cef into main May 1, 2023
@matthewp matthewp deleted the node-adapter-error branch May 1, 2023 14:08
@astrobot-houston astrobot-houston mentioned this pull request May 1, 2023
ematipico pushed a commit that referenced this pull request Feb 5, 2025
* Catch errors that occur within the stream in the Node adapter

* Adding a changeset

* Better error message on completely uncaught errors within the stream

* Update test
ematipico pushed a commit that referenced this pull request Feb 5, 2025
* Catch errors that occur within the stream in the Node adapter

* Adding a changeset

* Better error message on completely uncaught errors within the stream

* Update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors not caught in imported components / streaming broken chunks

3 participants