fix(@astrojs/tailwind): manually load postcss config file#5908
Merged
Conversation
🦋 Changeset detectedLatest commit: 7863f66 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
pkg: integration
Contributor
|
Thanks! Can you add a changeset? |
bluwy
reviewed
Jan 23, 2023
Member
bluwy
left a comment
bluwy
left a comment
There was a problem hiding this comment.
Looks great! with a couple of nits. Thanks for handling this unintentional regression 🙏
Member
Author
|
Made the requested changes |
bluwy
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes a bug spotted from the Astro discord: https://discord.com/channels/830184174198718474/1065463699508297758
The
@astrojs/tailwindintegration internally inlines the tailwind and autoprefixer plugins in the vite config, which causes vite to ignore loading postcss configuration files.This change aims to bring back the default behavior of vite, which is to load postcss config files only when there's no inline postcss configuration in the vite user config.
Testing
Manually tested
Docs
No docs needed, this is a bug fix