Add response iterator to node adapter#5418
Merged
matthewp merged 4 commits intowithastro:mainfrom Nov 16, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: be87f76 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
ematipico
pushed a commit
that referenced
this pull request
Feb 5, 2025
* add response iterator to node adapter * changeset * add node-fetch types * fix @types/node-fetch as a dev dep
ematipico
pushed a commit
that referenced
this pull request
Feb 5, 2025
* add response iterator to node adapter * changeset * add node-fetch types * fix @types/node-fetch as a dev dep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Sometimes Astro sends a ReadableStream or a Buffer as a response body and it raise an error
TypeError: body is not async iterable.I added a function to get a response iterator from different response types (sourced from apollo-client).
With this, node adapter can handle all the Astro response types.
Testing
Not implemented. I tested this in my project.
Docs
N/A