Migrate examples to type: module#4662
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: ddf7c39 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewp
approved these changes
Sep 7, 2022
Member
Author
|
We agreed to move forward with this but rollback the change from |
Member
|
Thanks for waiting @natemoo-re! I’ve opened withastro/docs#1514 to make the necessary docs changes. I’d also like to change one line in the Tailwind integration README: Want to update that |
delucis
approved these changes
Sep 9, 2022
Member
delucis
left a comment
There was a problem hiding this comment.
Thanks for taking care of that docs change!
ce6be71 to
bc733fa
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
"type": "module"in theirpackage.jsonfiles.vitestartersastro.config.jsinstead of the defensiveastro.config.mjsTesting
Manually
Docs
/cc @withastro/maintainers-docs for feedback!
We'd likely want to pair this change with a change to our docs to recommend
astro.config.jswith"type": "module"in thepackage.jsonfile.