small create-astro wording changes#3831
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 1007499 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
pkg: create-astro
5 tasks
delucis
reviewed
Jul 5, 2022
Member
delucis
left a comment
delucis
left a comment
There was a problem hiding this comment.
LGTM!
I think it would still be nice to have more information before an action rather than after accepting/rejecting a prompt. “optional” & “recommended” are a little vague, but still better than before.
And yeah, we should definitely bring over Sarah’s excellent template descriptions although that can happen in a follow-up PR.
tony-sull
approved these changes
Jul 7, 2022
Contributor
tony-sull
left a comment
tony-sull
left a comment
There was a problem hiding this comment.
lgtm! There's always more tweaking we can do here but I like the more friendly/conversational tone here 👍
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes