Handle malformed port in Host header without crashing - #17572
Open
matthewp wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: ffa6cf6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 399 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merging this PR will not alter performance
Comparing |
matthewp
marked this pull request as ready for review
August 2, 2026 16:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Hostheader (e.g.example.com:65536,example.com:8080:8080). The bad host made the request URL invalid, and the existingcatchfallback rebuilt the URL from the same host and threw again.buildRequestUrl(shared bycreateRequestFromNodeRequestandcreateRequest) now degrades in steps — full URL, origin only, then a server-controlled host (localhost, with the listening port when known) — so URL construction never throws.parseHostnow rejects a host with more than onehostname:portpair, which previously passed by inspecting only the first two colon-separated segments.Testing
node.test.tscovering malformed hosts throughcreateRequestFromNodeRequest(no throw, parseable URL) plus a valid max-port control, and acreateRequestcase asserting a duplicated-port host is rejected.@astrojs/nodetest that drives a standalone server, sends a craftedHostover a raw socket, and asserts a follow-up request still succeeds.Docs