Skip to content

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Nov 4, 2025

Changes

Testing

Should pass, manual

Docs

Changeset

@florian-lefebvre florian-lefebvre self-assigned this Nov 4, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2025

🦋 Changeset detected

Latest commit: 3f82093

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 4, 2025
@florian-lefebvre florian-lefebvre added pr preview Apply this label to a PR to generate a preview release and removed pkg: astro Related to the core `astro` package (scope) labels Nov 4, 2025
@github-actions github-actions bot removed the pr preview Apply this label to a PR to generate a preview release label Nov 4, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 4, 2025

npm i https://pkg.pr.new/astro@14713

commit: 8d571a3

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 4, 2025

CodSpeed Performance Report

Merging #14713 will not alter performance

Comparing feat/better-fonts-fallbacks (3f82093) with main (3d55c5d)

Summary

✅ 6 untouched

@RomanHauksson
Copy link

Hey Florian, thanks so much for this fix!

I tried to test out the patch locally on astro-fonts-bug, but the built index.html had the same size adjustment + overridden metrics as when I build it with the current Astro version. I also tried to test it on academic-project-astro-template but ran into some build errors.

For both of these, I probably just made a mistake when I tried to link the locally built version of Astro. I'd investigate this further to make sure it's not an issue with your patch, but I need to put this on the backburner so I can work on some assignments due this week. I can take another look this weekend, or someone else could double check it instead.

@delucis
Copy link
Member

delucis commented Nov 4, 2025

@RomanHauksson Thanks for testing! If you’d like to test it, the pkg.pr.new comment above might be easier as it provides a build you can install directly with npm.

Another thing to double check might be to rm -rf .astro in the project directory in case the values are cached there.

@florian-lefebvre
Copy link
Member Author

florian-lefebvre commented Nov 5, 2025

And in this case also removing node_modules/.astro. I tried locally on your repro and it seemed to work so I'm going to mark this as ready for review, but feel free to try on your side anyway!

@florian-lefebvre florian-lefebvre marked this pull request as ready for review November 5, 2025 08:52
@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 5, 2025
@florian-lefebvre florian-lefebvre merged commit 666d5a7 into main Nov 7, 2025
24 of 26 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/better-fonts-fallbacks branch November 7, 2025 18:51
natemoo-re pushed a commit to natemoo-re/astro that referenced this pull request Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants