Skip to content

Conversation

@florian-lefebvre
Copy link
Member

Changes

  • After RFC feedback, see Fonts roadmap#1039 (comment) pt 3
  • Basically unifont providers can return a priority for font files, to indicate which ones act as fallbacks. Only the google provider implements this, and we used to only download woff2 files. I made the filtering less agressive by allowing to get 1 fallback, usually woff

Testing

Unit test updated

Docs

Changeset

@florian-lefebvre florian-lefebvre self-assigned this Oct 31, 2025
@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2025

🦋 Changeset detected

Latest commit: 4fc5faf

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 31, 2025
@github-actions
Copy link
Contributor

📝 Changeset Validation Results

Changeset validation failed

Issues Found:

.changeset/three-apples-roll.md

Issue with: 'Fixes a case where the experimental Fonts API would filter available font files too aggressively, which could prevent the download of woff files when using the google provider'

❌ The "Fixes" verb should complete the sentence "This PR ...." However, the phrase starting 'Fixes a case...' is indirect. Adjust the phrasing for clarity.

💡 Rewrite the description for clarity, e.g., Fixes the issue where the experimental Fonts API prevented download of woff files when using the Google provider due to aggressive font file filtering.


📖 See Astro's changeset guide for details.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 31, 2025

CodSpeed Performance Report

Merging #14701 will not alter performance

Comparing fix/fonts-priority (4fc5faf) with main (f657183)1

Summary

✅ 6 untouched

Footnotes

  1. No successful run was found on main (be566b3) during the generation of this report, so f657183 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@florian-lefebvre florian-lefebvre merged commit 9be54c7 into main Oct 31, 2025
25 of 26 checks passed
@florian-lefebvre florian-lefebvre deleted the fix/fonts-priority branch October 31, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants