feat(assets): Always allow cropping and never upscale

[Princesseuh]

Changes

• Previously, you could only freeform resize an image if you specified width, height and fit. Failure to specify fit would result in a resize only based on width (or height, if you had only provided that). It's always been confusing tbh so this PR just removes that, if you specify both, we resize by both.
• You can still achieve the previous behavior by setting the fit to inside at least
• Closes getImage() silently fails to resize/crop images #13995 and Do not upscale images in the default image service #14465

Testing

Updated tests that tested old behaviour to test new behavior, ha

Docs

withastro/docs#12639

[changeset-bot]

⚠️ No Changeset found

Latest commit: 27479ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[florian-lefebvre]

Does this address #13995?

[Princesseuh]

Does this address #13995?

Yea

[florian-lefebvre]

Code LGTM, this is missing a changeset which can only be done after the docs PR

[Princesseuh]

There's a docs PR now, think I did it correctly

[florian-lefebvre]

@Princesseuh FYI we don't merge code PRs until the docs PR and the changeset are done now, you'll know next time :)