Skip to content

Conversation

@ellielok
Copy link

@ellielok ellielok commented Sep 18, 2025

Changes

Testing

All existing tests are passed when running pnpm run test

Docs

withastro/docs#12347

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2025

🦋 Changeset detected

Latest commit: 68a2d95

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) semver: major Change triggers a `major` release labels Sep 18, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

@ellielok ellielok marked this pull request as ready for review September 18, 2025 21:08
@ellielok
Copy link
Author

Some vercel tests in the CI fail because of 'test timed out after 50000ms'. I'm not sure why.

Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm re-running the failing testsn they're probably just flaky.

The docs team will comment on how we should proceed for v6 changes

@florian-lefebvre
Copy link
Member

@ellielok can you send a PR to the docs repo, against the v6 branch? There are more info in withastro/docs#12322

@ellielok
Copy link
Author

@ellielok can you send a PR to the docs repo, against the v6 branch? There are more info in withastro/docs#12322

Thanks for your reply. I've open a docs PR at withastro/docs#12347

@ascorbic ascorbic added this to the v6.0.0 milestone Sep 19, 2025
@sarah11918
Copy link
Member

Thank you for grabbing this issue and opening what I think is the very first PR for Astro v6.0!! Let's get this party started! 🥳

After the docs PR is finalized and approved, we can come back here and update the changeset to match!

(Some people will prefer to have/read the upgrade guidance in the astro repo itself, so the changeset will be kind of a duplicate of what we put in the upgrade guide for docs.)

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bringing over upgrade guide content for the changeset!

@florian-lefebvre florian-lefebvre merged commit c69c7de into withastro:next Sep 19, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) semver: major Change triggers a `major` release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants