Skip to content

Comments

Avoid Graphviz error when hiding all pins#375

Merged
17o2 merged 1 commit intorelease/v0.4.1-rcfrom
fix257
Jun 14, 2024
Merged

Avoid Graphviz error when hiding all pins#375
17o2 merged 1 commit intorelease/v0.4.1-rcfrom
fix257

Conversation

@kvid
Copy link
Collaborator

@kvid kvid commented Jun 5, 2024

This bug was reported in #257 more than 2.5 years ago, but is still present in v0.4, and can be triggered by e.g. this YAML input:

connectors:
  X1:
    pincount: 2
    hide_disconnected_pins: true
connections:
 - - X1

Graphviz reports an error when the HTML table of pins is empty.

This minor change should fix #257

@kvid kvid force-pushed the release/v0.4.1-rc branch from db1e77f to ddb2cba Compare June 7, 2024 23:49
@kvid kvid force-pushed the release/v0.4.1-rc branch from 661f3cf to 2d38267 Compare June 12, 2024 01:08
@kvid kvid requested a review from amotl June 12, 2024 10:00
@17o2 17o2 merged commit 2f4fe11 into release/v0.4.1-rc Jun 14, 2024
@17o2 17o2 deleted the fix257 branch June 14, 2024 13:18
@kvid kvid linked an issue Jun 22, 2024 that may be closed by this pull request
kvid added a commit that referenced this pull request Jul 5, 2024
lxander42 pushed a commit to lxander42/PipeViz that referenced this pull request Sep 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] hide_disconnected_pins when nothing is connected

3 participants