Skip to content

Comments

Update .gitignore#256

Merged
amotl merged 1 commit intowireviz:masterfrom
daq-tools:amo/update-ignore
Sep 8, 2023
Merged

Update .gitignore#256
amotl merged 1 commit intowireviz:masterfrom
daq-tools:amo/update-ignore

Conversation

@amotl
Copy link
Member

@amotl amotl commented Oct 23, 2021

Hi Daniel,

I removed this commit from #254 and hereby handing it in seperately.

With kind regards,
Andreas.


Add two more folders to be ignored.

  • .idea: Used by PyCharm
  • .venv: My convention for creating virtualenvs

Copy link
Collaborator

@kvid kvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems useful

Add two more folders to be ignored.

- .idea: Used by PyCharm
- .venv: My convention for creating virtualenvs
@amotl amotl force-pushed the amo/update-ignore branch from ba66e50 to eba0004 Compare September 8, 2023 18:42
@amotl amotl merged commit a16f2e4 into wireviz:master Sep 8, 2023
@amotl amotl deleted the amo/update-ignore branch September 8, 2023 18:49
kvid pushed a commit to kvid/WireViz that referenced this pull request Sep 8, 2023
Add two more folders to be ignored.

- .idea: Used by PyCharm
- .venv: My convention for creating virtualenvs
kvid added a commit to kvid/WireViz that referenced this pull request Sep 8, 2023
@kvid
Copy link
Collaborator

kvid commented Sep 8, 2023

I'm sorry that I approved this without noticing a couple of things that should have been fixed first:

  • PR changes should normally have dev as base branch to collect changes for the next ordinary release, unless it's important to update the master branch before the next ordinary release (like a hotfix release).
  • CHANGELOG.md should be updated with a notice as part of the PR.

As your change doesn't change any code, no big harm is done, and I don't see any reason to create a hotfix release for this commit added to master. However, I've also added your commit plus a notice in CHANGELOG.md to the dev branch.

lxander42 pushed a commit to lxander42/PipeViz that referenced this pull request Sep 20, 2025
Add two more folders to be ignored.

- .idea: Used by PyCharm
- .venv: My convention for creating virtualenvs
lxander42 pushed a commit to lxander42/PipeViz that referenced this pull request Sep 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants