Conversation
- partial fix for wireviz#7 - based on and closes wireviz#161 and wireviz#162
|
Thanks. |
@formatc1702, Are you not able to add If not, it might be an option to use the GitHub GUI to merge-in to a different branch, e.g. a new dummy |
|
Good idea with the dummy branch! Thanks. I could have done it in the GitHub GUI (just like I did now), but I wasn't sure it would work as intended, so I decided to do it locally, and didn't realize I could not just manually mark the PR as merged afterwards. And as I just realized, when doing it via GitHub, you are marked as the main author (see 3c205fe *, will delete later); whereas I interactively rebased everything by squashing onto zombielinux' commit, making him the main author (see dec64ab), which is closer to my intention, since he kick-started this chain of PRs. [*] I just copy&pasted the commit message from dec64ab, that's why zombielinux is missing entirely in 3c205fe Anyway, now I know, for next time! |

dev